Shares my faith,
Is great with kids,
Loves to read, although not necessarily the same things I do,
Was willing to move my children's book collection, several times!
Loves to cook, and is willing to do his share of the cooking and the cleaning up. In fact, before I retired from teaching, he usually had supper at least going, if not ready, by the time I got home. After a day of dealing with middle school kids, and a 45-60 minute drive home in heavy traffic, it was wonderful to come home and not have to cook,
Has a beautiful singing voice, especially worship songs, and is not ashamed to sing out,
Gave me a boxed set of "The Lord of the Rings" for HIS birthday the first year we were dating. I had never read them, and it started me reading SF for the first time.
One of the most important: He never, ever, criticizes me in public, or talks me down even to his friends. (And I show him the same respect!)
We'll celebrate our 35th anniversary in December.