20ish years ago, Breyer's Rocky Road was my favorite, but they changed the recipe to a marshmallow swirl instead of whole mini marshmallows. I like the marshmallows better than the swirl, but all the Rocky Roads I find have a swirl now.
I suppose it's just as well, because I don't really care for nuts or other crunchy things in my ice cream anymore.
I'm currently in love with Blue Bell's Banana Pudding ice cream. I also try various Ben & Jerry's. Currently my top flavor is the new(?) Willie Nelson Peach. I find that I like some of their ice cream mixes, but not the mixed in stuff. Karamel Sutra rocks with it's core of soft caramel goodness, but I don't care for the fudge chips mixed into the ice cream. Phish Food is a good chocolate with marshmallow and caramel swirl, but again.. I don't like the fudge fish. While these two examples make it sound like I just don't like the hard fudge they use (and that's completely true, I don't), there's others I don't quite love because there's hard bits of stuff in them. I just like my ice cream to be soft & creamy all the way through.